rafaelweingartner commented on a change in pull request #2417: Fix errors that
appeared after #2283
URL: https://github.com/apache/cloudstack/pull/2417#discussion_r162898993
##########
File path:
engine/storage/integration-test/src/test/java/com/cloud/vm/snapshot/dao/VmSnapshotDaoTest.java
##########
@@ -41,7 +39,7 @@
@Test
public void testVmSnapshotDetails() {
- VMSnapshotDetailsVO detailsVO = new VMSnapshotDetailsVO(1L, "test",
"foo", display);
+ VMSnapshotDetailsVO detailsVO = new VMSnapshotDetailsVO(1L, "test",
"foo", true);
Review comment:
I have no idea why sometimes it compiles. It should not per Java specs. You
cannot have a `package` declaration in `x.y.z` and then put this same class in
a folder structure as `x.y.z.z`.
The thing called `display` there is nothing. It is not a variable, it is
nothing... We need a boolean variable/value here. This looks like something
that eclipse generated when using the refactor feature.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
