borisstoyanov commented on issue #2406: CLOUDSTACK-9663 return role on updateRole URL: https://github.com/apache/cloudstack/pull/2406#issuecomment-360428975 marvin test changes looks good @dhlaluku. I'll wait until smoketests complete. ``` [root@trl-1192-k-cs411-bstoyanov-marvin ~]# cat /marvin//MarvinLogs/test_dynamicroles_0FID28/results.txt Test to ensure 4 default roles cannot be deleted ... === TestName: test_default_role_deletion | Status : SUCCESS === ok Test to check role, role permissions and account life cycles ... === TestName: test_role_account_acls | Status : SUCCESS === ok Test for role-rule enforcement in case of multiple mgmt servers ... === TestName: test_role_account_acls_multiple_mgmt_servers | Status : SUCCESS === ok Test to ensure role in use cannot be deleted ... === TestName: test_role_inuse_deletion | Status : SUCCESS === ok Tests normal lifecycle operations for roles ... === TestName: test_role_lifecycle_create | Status : SUCCESS === ok Tests role update ... === TestName: test_role_lifecycle_delete | Status : SUCCESS === ok Tests that default four roles exist ... === TestName: test_role_lifecycle_list | Status : SUCCESS === ok Tests role update ... === TestName: test_role_lifecycle_update | Status : SUCCESS === ok Tests role update when role is in use by an account ... === TestName: test_role_lifecycle_update_role_inuse | Status : SUCCESS === ok Tests concurrent order updation of role permission ... === TestName: test_rolepermission_lifecycle_concurrent_updates | Status : SUCCESS === ok Tests creation of role permission ... === TestName: test_rolepermission_lifecycle_create | Status : SUCCESS === ok Tests deletion of role permission ... === TestName: test_rolepermission_lifecycle_delete | Status : SUCCESS === ok Tests listing of default role's permission ... === TestName: test_rolepermission_lifecycle_list | Status : SUCCESS === ok Tests order updation of role permission ... === TestName: test_rolepermission_lifecycle_update | Status : SUCCESS === ok Tests update of Allow to Deny permission of a rule ... === TestName: test_rolepermission_lifecycle_update_permission | Status : SUCCESS === ok Tests negative test for setting incorrect value as permission ... === TestName: test_rolepermission_lifecycle_update_permission_negative | Status : SUCCESS === ok ---------------------------------------------------------------------- Ran 16 tests in 42.563s OK ```
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
