khos2ow commented on issue #2433: Fix and enhance package script URL: https://github.com/apache/cloudstack/pull/2433#issuecomment-361988035 @rhtyd @rafaelweingartner > Please see outstanding comments, what you're trying to achieve may be done in two ways - (a) introduce a new parameter that is used for the DEFREL option (as provided), (b) use sed to replace the value for DEFREL in your build script/process As Rafael mentioned, this was exactly the point of my PR, to prevent hacking around packaging and have predictable package name based on POM version (most probably if one needs to have a branding to be able to differentiate between custom built and official built). My first approach was actually to have another flag (`-b, --brand NAME`) but I removed it right away, because I, myself, forgot to update my Jenkins job although I had changed the POM version. > I find the idea of providing a parameter interesting, but it is also interesting to load everything out of the pom. This makes sense too. I guess for sake of completeness we can still have `-b, --brand` flag and this will force override the _auto detected_ branding from POM version. > For several package/build scripts to continue to work, please don't remove the -o option, and keep changes in the package.sh script restricted to accepting the brand string only. I did find that `-o` flag was removed in #46 and it wasn't doing anything at all for more than three years and because of the flaw in reading `ARGS` it was never caught. (i.e. this section `*) shift ;;` was silently ignoring unknown flag rather than breaking the build). And btw, this PR doesn't change anything on the suffix of package name, for example `el7.centos.x86_64` part is unchanged in the scope of this PR.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
