DaanHoogland commented on a change in pull request #2445: CLOUDSTACK-10218: fix
for forced network update in a nuage network
URL: https://github.com/apache/cloudstack/pull/2445#discussion_r166047276
##########
File path:
plugins/network-elements/nuage-vsp/src/com/cloud/network/guru/NuageVspGuestNetworkGuru.java
##########
@@ -470,14 +468,14 @@ public void reserve(NicProfile nic, Network network,
VirtualMachineProfile vm, D
HostVO nuageVspHost =
_nuageVspManager.getNuageVspHost(network.getPhysicalNetworkId());
VspNetwork vspNetwork =
_nuageVspEntityBuilder.buildVspNetwork(vm.getVirtualMachine().getDomainId(),
network);
- if (vm.getType() == VirtualMachine.Type.DomainRouter &&
vspNetwork.getVirtualRouterIp().equals("null")) {
+ boolean isUpgradeNetworkOffering = vm.getType() ==
VirtualMachine.Type.DomainRouter && vspNetwork.getVirtualRouterIp()
Review comment:
isn't it possible that the old offering had a virtual router as well? it
seems to me that only oldOffering.equals(newOffering) is a proper test here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
