rafaelweingartner commented on a change in pull request #2231:
[CLOUDSTACK-10039] Adding IOPS/GB offering
URL: https://github.com/apache/cloudstack/pull/2231#discussion_r170310373
##########
File path:
server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java
##########
@@ -2566,6 +2567,61 @@ protected DiskOfferingVO createDiskOffering(final Long
userId, final Long domain
isCustomized = true;
}
+ if (minIopsPerGb != null || maxIopsPerGb != null) {
+
+ if (!isCustomized) {
+ throw new InvalidParameterValueException("Cannot set Min/Max
IOPS/GB for a fixed size disk offering");
+ }
+
+ if ((isCustomizedIops != null && isCustomizedIops) || minIops !=
null || maxIops != null) {
+ throw new InvalidParameterValueException("Cannot set Min/Max
IOPS/GB with either " +
+ "custom IOPS or fixed IOPS");
+ }
+
+ if (minIopsPerGb != null && maxIopsPerGb != null) {
Review comment:
Could you extract this block to a specific method? Document it, and write
unit tests for it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
