rafaelweingartner commented on a change in pull request #2231:
[CLOUDSTACK-10039] Adding IOPS/GB offering
URL: https://github.com/apache/cloudstack/pull/2231#discussion_r170311638
##########
File path: server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java
##########
@@ -916,29 +951,34 @@ public VolumeVO resizeVolume(ResizeVolumeCmd cmd) throws
ResourceAllocationExcep
// no parameter provided; just use the original size of the
volume
newSize = volume.getSize();
}
-
+ newSizeInGb = newSize >> 30;
Review comment:
Let's not use bit shift here. It makes things harder to read and understand.
The code is already convoluted enough
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
