rafaelweingartner commented on issue #2454: CLOUDSTACK-10283: Sudo to setup agent keystore, fail on host add failure URL: https://github.com/apache/cloudstack/pull/2454#issuecomment-368455248 I am sorry @rhtyd, but I find using merge commits when merging PRs a good idea. We do not have a protocol for merges yet (use or not use the merge commit). There was a thread a while ago discussing this topic in [1]. Some people preferred maintaining the merge commits when merging a PR (myself included). However, the thread died after a while, I believe the author (Daan) was busy with something else to finalize the discussion and create something formal. [1] http://mail-archives.apache.org/mod_mbox/cloudstack-dev/201801.mbox/%3CCAGQtxva9xnipUXvc56wA4NT5fuwLXzR3cpD%3DFf1mO%3DxZYoKQ7w%40mail.gmail.com%3E
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
