DaanHoogland commented on a change in pull request #2474: CLOUDSTACK-10246 Fix 
Host HA and VM HA issues
URL: https://github.com/apache/cloudstack/pull/2474#discussion_r171785154
 
 

 ##########
 File path: 
server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java
 ##########
 @@ -340,6 +340,7 @@
     private ScheduledExecutorService _executor;
     private ScheduledExecutorService _checkExecutor;
     private ScheduledExecutorService _networkStatsUpdateExecutor;
+    private ExecutorService _routerOobStartExecutor;
 
 Review comment:
   we are trying to get rid of these _'s . no need to adhere to this old 
convention. In fact you may want to rename the others as well (in a separate 
commit for review ease) (this is not a request for change, just a suggestion)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to