DaanHoogland commented on a change in pull request #2474: CLOUDSTACK-10246 Fix
Host HA and VM HA issues
URL: https://github.com/apache/cloudstack/pull/2474#discussion_r171785409
##########
File path:
server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java
##########
@@ -2587,7 +2589,13 @@ public boolean postStateTransitionEvent(final
StateMachine2.Transition<VirtualMa
event == VirtualMachine.Event.FollowAgentPowerOnReport &&
newState == VirtualMachine.State.Running &&
isOutOfBandMigrated(opaque)) {
- s_logger.debug("Virtual router " + vo.getInstanceName() + " is
powered-on out-of-band");
+ /* Since vRouter appears to be powered-on OOB, make sure we can
talk to router
+ * If we can't talk to it, we need to reboot it to get it managed
correctly
+ * This is needed for example when a host agent goes down and
comes back up,
+ * we would have done a failed HA event on the router and end up
having our controlIP out-of-sync
+ */
+ s_logger.info("Router " + vo.getInstanceName() + " (ID:" +
vo.getId() + ") is powered-on out-of-band, checking if can send
CheckRouterCommand to router");
Review comment:
:+1: completely agree with this change, the ecosystem shouldn't rely on
debug logging anyway. friendliness to the community dictates diligent testing
anyway.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
