ustcweizhou commented on a change in pull request #2476: CLOUDSTACK-10317: Fix 
SNAT rules for additional public nics
URL: https://github.com/apache/cloudstack/pull/2476#discussion_r172535132
 
 

 ##########
 File path: systemvm/debian/opt/cloud/bin/cs/CsAddress.py
 ##########
 @@ -388,7 +388,7 @@ def fw_router(self):
             self.fw.append(["mangle", "",
                             "-A VPN_%s -j RETURN" % self.address['public_ip']])
             self.fw.append(["nat", "",
-                            "-A POSTROUTING -o eth2 -j SNAT --to-source %s" % 
self.address['public_ip']])
+                            "-A POSTROUTING -o %s -j SNAT --to-source %s" % 
(self.dev, self.address['public_ip'])])
 
 Review comment:
   @DagSonsteboSB yes, I think the outgoing IP for the vms without static nat 
should be the source nat IP, in your example 10.100.1.10
   
   In my point of view, the rules applied on ethernet other than eth2 (for 
example eth3) are not needed at all, however it is not harmful to have them. 
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to