rhtyd commented on a change in pull request #2472: CLOUDSTACK-10310 Fix KVM reboot on storage issue URL: https://github.com/apache/cloudstack/pull/2472#discussion_r175337493
########## File path: scripts/vm/hypervisor/kvm/kvmheartbeat.sh ########## @@ -155,10 +155,10 @@ then exit 0 elif [ "$cflag" == "1" ] then - /usr/bin/logger -t heartbeat "kvmheartbeat.sh rebooted system because it was unable to write the heartbeat to the storage." + /usr/bin/logger -t heartbeat "kvmheartbeat.sh stopped cloudstack-agent because it was unable to write the heartbeat to the storage." sync & sleep 5 - echo b > /proc/sysrq-trigger + service cloudstack-agent stop Review comment: Maybe you can re-send the PR in two parts, the first half that increases the heartbeat retry threshold to `5` LGTM. The second part could be the configuration fix, global setting or setting in agent.properties to decide whether to reboot kvm host or stop agent. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
