marcaurele commented on issue #2481: CLOUDSTACK-10320 - Invalid pair for 
response object breaking response parsing
URL: https://github.com/apache/cloudstack/pull/2481#issuecomment-374269828
 
 
   The default isolation level in CS is `read-committed` 
(https://github.com/apache/cloudstack/blob/master/framework/db/src/main/java/com/cloud/utils/db/TransactionLegacy.java#L1044)
 but not `repeatable-read`, except if you explicitly set it in the 
`db.properties` file. If the default value is change, and I modify the PR to 
use a transaction around those 2 SQL read operations, the issue is fixed, but...
   
   Changing the default isolation level will certainly have an impact on 
performance on the database 
(https://www.percona.com/blog/2015/01/14/mysql-performance-implications-of-innodb-isolation-modes/).
 So, I'll change the PR to only have a repeatable-read isolation for those set 
of methods, and will try to measure how it performs.
   
   If people are willing to test in their environment (quite loaded) the global 
isolation level change, it would be interesting to hear the performance 
outcomes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to