rafaelweingartner commented on a change in pull request #2510:
CLOUDSTACK-10334: Fix inadequate information for handling catch clauses
URL: https://github.com/apache/cloudstack/pull/2510#discussion_r176784389
##########
File path: server/src/main/java/com/cloud/api/dispatch/ParamProcessWorker.java
##########
@@ -258,11 +258,11 @@ public void processParameters(final BaseCmd cmd, final
Map params) {
}
} catch (final IllegalArgumentException e) {
- s_logger.error("Error initializing command " +
cmd.getCommandName() + ", field " + field.getName() + " is not accessible.");
+ s_logger.error("Error initializing command " +
cmd.getCommandName() + ", field " + field.getName() + " is not accessible.", e);
Review comment:
Why do you need to log the stack trace twice? I mean, the exception is
re-thrown as a cloudruntime. Wherever it is catch, it will probably be logged.
In the Jira ticket you mention that the problem (confusion) is caused by the
same message in the stack trace. Why not improve the messaging then, instead of
logging printing the strack trace twice?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
