olivierlemasle commented on a change in pull request #2498: CLOUDSTACK-10327: 
Do not invalidate the session when API command not found
URL: https://github.com/apache/cloudstack/pull/2498#discussion_r177023277
 
 

 ##########
 File path: server/src/com/cloud/api/ApiServer.java
 ##########
 @@ -958,6 +959,9 @@ private boolean commandAvailable(final InetAddress 
remoteAddress, final String c
         } catch (final RequestLimitException ex) {
             s_logger.debug(ex.getMessage());
             throw new ServerApiException(ApiErrorCode.API_LIMIT_EXCEED, 
ex.getMessage());
+        }  catch (final UnavailableCommandException ex) {
+            s_logger.debug(ex.getMessage());
+            throw new 
ServerApiException(ApiErrorCode.UNSUPPORTED_ACTION_ERROR, ex.getMessage());
 
 Review comment:
   @rhtyd I'm not sure I understand your suggestion. The Http error code is 
specified here, in line 964). The `ServerApiException` is caught on 
`ApiServlet` which generates the HTTP response.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to