nitin-maharana commented on a change in pull request #2512: Only use the host
if its Resource State is Enabled.
URL: https://github.com/apache/cloudstack/pull/2512#discussion_r177230153
##########
File path:
engine/storage/snapshot/src/main/java/org/apache/cloudstack/storage/snapshot/StorageSystemSnapshotStrategy.java
##########
@@ -474,7 +473,7 @@ else if (volumeInfo.getFormat() == ImageFormat.OVA ||
volumeInfo.getFormat() ==
try {
vmSnapshot = takeHypervisorSnapshot(volumeInfo);
}
- catch (ResourceAllocationException ex) {
+ catch (Exception ex) {
Review comment:
@mike-tutkowski, Thanks for the fix. I think it would be better to capture
the required exceptions with multiple catches instead of the parent Exception
class. We can always put this at the end.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
