rhtyd commented on a change in pull request #2508: WIP - CLOUDSTACK-9114:
Reduce VR downtime during network restart
URL: https://github.com/apache/cloudstack/pull/2508#discussion_r177392423
##########
File path: server/src/com/cloud/network/element/VirtualRouterElement.java
##########
@@ -227,7 +227,7 @@ public boolean implement(final Network network, final
NetworkOffering offering,
final List<DomainRouterVO> routers =
routerDeploymentDefinition.deployVirtualRouter();
int routerCounts = 1;
- if (offering.getRedundantRouter()) {
+ if (offering.getRedundantRouter() || network.isRollingRestart()) {
Review comment:
Unlikely we'll have more than 2 routers for redundancy. However, the code
has an internal limit of 5 (after which it logs warning/errors that a network
has more than 5 routers, which can happen in some edge cases).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
