rafaelweingartner commented on a change in pull request #2508: CLOUDSTACK-9114:
Reduce VR downtime during network restart
URL: https://github.com/apache/cloudstack/pull/2508#discussion_r178031428
##########
File path:
engine/orchestration/src/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java
##########
@@ -2838,8 +2828,27 @@ public boolean restartNetwork(final Long networkId,
final Account callerAccount,
s_logger.debug("Restarting network " + networkId + "...");
final ReservationContext context = new ReservationContextImpl(null,
null, callerUser, callerAccount);
+ final NetworkOffering offering =
_networkOfferingDao.findByIdIncludingRemoved(network.getNetworkOfferingId());
if (cleanup) {
Review comment:
What about extracting this IF body to a method? This allows proper
documentation (instead of code comments), and unit tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
