rafaelweingartner commented on a change in pull request #2508: CLOUDSTACK-9114:
Reduce VR downtime during network restart
URL: https://github.com/apache/cloudstack/pull/2508#discussion_r178033706
##########
File path: server/src/com/cloud/network/vpc/VpcManagerImpl.java
##########
@@ -2435,4 +2460,66 @@ public boolean isSrcNatIpRequired(long vpcOfferingId) {
final Map<Network.Service, Set<Network.Provider>>
vpcOffSvcProvidersMap = getVpcOffSvcProvidersMap(vpcOfferingId);
return
vpcOffSvcProvidersMap.get(Network.Service.SourceNat).contains(Network.Provider.VPCVirtualRouter);
}
+
+ private boolean rollingRestartVpc(final Vpc vpc, final
List<DomainRouterVO> oldRouters, final ReservationContext context) throws
ResourceUnavailableException, ConcurrentOperationException,
InsufficientCapacityException {
Review comment:
This method has a good chunk of code duplicated with
`rollingRestartRouters`. Would mind extracting the code common code to methods
and then reuse them?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
