rafaelweingartner commented on a change in pull request #2505:
CLOUDSTACK-10333: Secure Live VM Migration for KVM
URL: https://github.com/apache/cloudstack/pull/2505#discussion_r178034614
##########
File path: agent/src/com/cloud/agent/Agent.java
##########
@@ -274,6 +279,19 @@ public void start() {
}
}
_shell.updateConnectedHost();
+
+ // In case of software based restart, GC to remove old instances
+ _executor.submit(new Runnable() {
Review comment:
Got it. There is only one thing. We never now for sure that the GC has been
executed. `System.gc` only suggests for the JVM that the GC can be executed,
but there is no guarantees. Anyways, as long as the old objects are not used
anymore we are safe to go.
Would you mind extracting this block of code to a method and document it
with this explanation?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
