rafaelweingartner commented on a change in pull request #2505:
CLOUDSTACK-10333: Secure Live VM Migration for KVM
URL: https://github.com/apache/cloudstack/pull/2505#discussion_r178034861
##########
File path: agent/src/com/cloud/agent/Agent.java
##########
@@ -140,9 +143,11 @@ public int value() {
long _startupWait = _startupWaitDefault;
boolean _reconnectAllowed = true;
//For time sentitive task, e.g. PingTask
- private final ThreadPoolExecutor _ugentTaskPool;
+ ThreadPoolExecutor _ugentTaskPool;
ExecutorService _executor;
+ Thread _shutdownThread = new ShutdownThread(this);
Review comment:
Awesome! Thanks!
This is a cosmetic thing, but if we do not get ride of them, newcomers might
think that we enforce them. I am trying to do the same in other PRs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
