mike-tutkowski commented on a change in pull request #2503: Support multiple 
volume access groups per compute cluster
URL: https://github.com/apache/cloudstack/pull/2503#discussion_r178153566
 
 

 ##########
 File path: 
plugins/hypervisors/vmware/src/main/java/com/cloud/storage/resource/VmwareStorageProcessor.java
 ##########
 @@ -2956,6 +3033,61 @@ public void handleTargets(boolean add, 
ModifyTargetsCommand.TargetTypeToRemove t
         }
     }
 
+    private String waitForDatastoreName(HostDatastoreSystemMO 
hostDatastoreSystemMO, String iqn) throws Exception {
+        long secondsToWait = 120;
 
 Review comment:
   I hadn't planned to. In almost every case, the datastore will mount in under 
30 seconds. 120 is really a super worst-case scenario. If we have waited that 
long and not see the datastore mounted yet, just fail. The normal case is the 
datastore will mount in 5 - 10 seconds and we won't get anywhere near 120 
seconds.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to