rafaelweingartner commented on a change in pull request #2404:
[CLOUDSTACK-10230] User should not be able to use removed “Guest OS type”
URL: https://github.com/apache/cloudstack/pull/2404#discussion_r178526830
##########
File path: server/src/main/java/com/cloud/vm/UserVmManagerImpl.java
##########
@@ -6458,4 +6423,4 @@ private boolean checkStatusOfVolumeSnapshots(long vmId,
Volume.Type type) {
}
return false;
}
-}
+}
Review comment:
Yeas, it is.
That is why I am not doing like this anymore. I am always splitting up the
PR into multiple commits. It was one of your suggestions some time ago, which I
liked. However, I created this PR before that.
The changes are basically at lines 2380-2424.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
