rafaelweingartner commented on a change in pull request #2553: Update 
inconsistent debugging info in catch block
URL: https://github.com/apache/cloudstack/pull/2553#discussion_r179924905
 
 

 ##########
 File path: 
api/src/main/java/org/apache/cloudstack/api/command/user/firewall/CreatePortForwardingRuleCmd.java
 ##########
 @@ -358,7 +358,7 @@ public void create() {
             setEntityId(result.getId());
             setEntityUuid(result.getUuid());
         } catch (NetworkRuleConflictException ex) {
-            s_logger.info("Network rule conflict: " + ex.getMessage());
+            s_logger.info("Network rule conflict: ", ex);
 
 Review comment:
   I would suggest removing the info one because we have a throw exception that 
we can send the `ex` exception.
   
   BTW: thanks for your PRs lately. We really need this tasks of cleaning up 
and standardization of log messages an exceptions.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to