rafaelweingartner commented on a change in pull request #2553: Update 
inconsistent debugging info in catch block
URL: https://github.com/apache/cloudstack/pull/2553#discussion_r181085940
 
 

 ##########
 File path: 
api/src/main/java/org/apache/cloudstack/api/command/user/firewall/CreateFirewallRuleCmd.java
 ##########
 @@ -254,7 +254,6 @@ public void create() {
                 setEntityUuid(result.getUuid());
             }
         } catch (NetworkRuleConflictException ex) {
-            s_logger.info("Network rule conflict: " + ex.getMessage());
             s_logger.trace("Network Rule Conflict: ", ex);
             throw new 
ServerApiException(ApiErrorCode.NETWORK_RULE_CONFLICT_ERROR, ex.getMessage());
 
 Review comment:
   Ah, I am so sorry. I meant the second constructor. 
   What I wanted to say is that it might be better to change the 
`ex.getMessage` to `ex`. This will maintain the full stack trace.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to