rhtyd commented on a change in pull request #2566: ConfigDrive fixes: CLOUDSTACK-10288, CLOUDSTACK-10289 URL: https://github.com/apache/cloudstack/pull/2566#discussion_r181163582
########## File path: services/secondary-storage/server/src/org/apache/cloudstack/storage/resource/NfsSecondaryStorageResource.java ########## @@ -480,7 +480,7 @@ public Answer createConfigDriveIsoForVM(HandleConfigDriveIsoCommand cmd) { for (String[] item : cmd.getVmData()) { String dataType = item[CONFIGDATA_DIR]; String fileName = item[CONFIGDATA_FILE]; - String content = item[CONFIGDATA_CONTENT]; + String content = item[CONFIGDATA_CONTENT]; // base64 Review comment: you can rename the variable to `base64Content` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services