nitin-maharana commented on a change in pull request #2508: CLOUDSTACK-9114: 
Reduce VR downtime during network restart
URL: https://github.com/apache/cloudstack/pull/2508#discussion_r181297798
 
 

 ##########
 File path: ui/scripts/network.js
 ##########
 @@ -1100,11 +1100,23 @@
                                         });
                                         
args.$form.find('.form-item[rel=cleanup]').find('input').attr('checked', 
'checked'); //checked
                                         
args.$form.find('.form-item[rel=cleanup]').css('display', 'inline-block'); 
//shown
+                                        
args.$form.find('.form-item[rel=makeredundant]').find('input').attr('checked', 
'checked'); //checked
+                                        
args.$form.find('.form-item[rel=makeredundant]').css('display', 
'inline-block'); //shown
+
+                                        if 
(Boolean(args.context.networks[0].redundantrouter)) {
 
 Review comment:
   @rhtyd, When we say redundant networks, that means it already contains the 
new upgraded VR(after Blue-Green deployment), we created after a restart? If 
that is the case, I think it would be great, if we give a different name 
instead of redundant. Because there is a chance we will misinterpret as RVR.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to