DaanHoogland commented on a change in pull request #2559: Upgrade path 4.11
through 4.11.1 to 4.12
URL: https://github.com/apache/cloudstack/pull/2559#discussion_r181340380
##########
File path:
engine/schema/src/test/java/com/cloud/upgrade/DatabaseUpgradeCheckerTest.java
##########
@@ -74,6 +77,30 @@ public void testCalculateUpgradePath490to4910() {
}
+ @Test
+ public void testCalculateUpgradePath410to412() {
+
+ final CloudStackVersion dbVersion =
CloudStackVersion.parse("4.10.0.0");
+ assertNotNull(dbVersion);
+
+ final CloudStackVersion currentVersion =
CloudStackVersion.parse("4.12.0.0");
+ assertNotNull(currentVersion);
+
+ final DatabaseUpgradeChecker checker = new DatabaseUpgradeChecker();
+ final DbUpgrade[] upgrades = checker.calculateUpgradePath(dbVersion,
currentVersion);
+
+ assertNotNull(upgrades);
+ assertTrue(upgrades.length >= 1);
+ assertTrue(upgrades[0] instanceof Upgrade41000to41100);
+ assertTrue(upgrades[1] instanceof Upgrade41100to41110);
+ assertTrue(upgrades[2] instanceof Upgrade41110to41200);
+
+ assertTrue(Arrays.equals(new String[] { "4.11.0.0", "4.11.1.0"},
Review comment:
No i mean that the items are implicetly tested by the other checks in this
test and also in other tests the completeness of the array is tested, therefore
I am assuming it here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
