rafaelweingartner commented on a change in pull request #2562: consoleproxy: 
use consoleproxy.domain for non-ssl enable env
URL: https://github.com/apache/cloudstack/pull/2562#discussion_r181356856
 
 

 ##########
 File path: core/src/com/cloud/info/ConsoleProxyInfo.java
 ##########
 @@ -55,6 +57,9 @@ public ConsoleProxyInfo(boolean sslEnabled, String 
proxyIpAddress, int port, int
                 proxyImageUrl += ":" + this.proxyUrlPort;
         } else {
             proxyAddress = proxyIpAddress;
+            if (!Strings.isNullOrEmpty(consoleProxyUrlDomain)) {
 
 Review comment:
   Well the java dos they just mention empty, and not blank. I checked their 
code, and they do not check for blank.
   
   Test code:
   ```
       public static void main(String[] args) {
           System.out.println("Using Guava Strings suite");
           System.out.println("Result for empty: " + Strings.isNullOrEmpty(""));
           System.out.println("Result for null " + Strings.isNullOrEmpty(null));
           System.out.println("Result for blank: " + Strings.isNullOrEmpty("    
   "));
           System.out.println();
           System.out.println("Using Apache commns lang");
           System.out.println("Result for empty: " + StringUtils.isBlank(""));
           System.out.println("Result for null " + StringUtils.isBlank(null));
           System.out.println("Result for blank: " + StringUtils.isBlank("      
 "));
       }
   ```
   
   Result:
   ```
   Using Guava Strings suite
   Result for empty: true
   Result for null true
   Result for blank: false
   
   Using Apache commns lang
   Result for empty: true
   Result for null true
   Result for blank: true
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to