rhtyd commented on issue #2576: Fix Python code checkstyle execute by "systemvm\test\runtests.sh" URL: https://github.com/apache/cloudstack/pull/2576#issuecomment-381879043 Thanks @rafaelweingartner I see the issue is Travis related, thanks for fixing. I've left some remarks. Also, the Travis failure affects 4.11 branch too, can you rebase and edit this PR against 4.11? Locally unable to reproduce the issue; On 4.11, I get this: ``` > bash -x runtests.sh + export PYTHONPATH=../debian/opt/cloud/bin/ + PYTHONPATH=../debian/opt/cloud/bin/ + export PYTHONDONTWRITEBYTECODE=False + PYTHONDONTWRITEBYTECODE=False + echo 'Running pep8 to check systemvm/python code for errors' Running pep8 to check systemvm/python code for errors + pep8 --max-line-length=179 TestCsAddress.py TestCsApp.py TestCsCmdLine.py TestCsConfig.py TestCsDatabag.py TestCsDhcp.py TestCsFile.py TestCsGuestNetwork.py TestCsHelper.py TestCsInterface.py TestCsNetfilter.py TestCsProcess.py TestCsRedundant.py TestCsRoute.py TestCsRule.py ++ find ../debian -name '*.py' + pep8 --max-line-length=179 --exclude=monitorServices.py,baremetal-vr.py,passwd_server_ip.py ../debian/opt/cloud/bin/cs_loadbalancer.py ../debian/opt/cloud/bin/configure.py ../debian/opt/cloud/bin/master.py ../debian/opt/cloud/bin/cs_ip.py ../debian/opt/cloud/bin/update_config.py ../debian/opt/cloud/bin/cs_guestnetwork.py ../debian/opt/cloud/bin/passwd_server_ip.py ../debian/opt/cloud/bin/cs_staticroutes.py ../debian/opt/cloud/bin/cs_dhcp.py ../debian/opt/cloud/bin/cs_vpnusers.py ../debian/opt/cloud/bin/set_redundant.py ../debian/opt/cloud/bin/cs_remoteaccessvpn.py ../debian/opt/cloud/bin/baremetal-vr.py ../debian/opt/cloud/bin/cs_monitorservice.py ../debian/opt/cloud/bin/cs_site2sitevpn.py ../debian/opt/cloud/bin/merge.py ../debian/opt/cloud/bin/cs_vmp.py ../debian/opt/cloud/bin/cs_forwardingrules.py ../debian/opt/cloud/bin/cs_vmdata.py ../debian/opt/cloud/bin/vmdata.py ../debian/opt/cloud/bin/cs/CsStaticRoutes.py ../debian/opt/cloud/bin/cs/CsFile.py ../debian/opt/cloud/bin/cs/CsDhcp.py ../debian/opt/cloud/bin/cs/CsDatabag.py ../debian/opt/cloud/bin/cs/CsProcess.py ../debian/opt/cloud/bin/cs/CsRoute.py ../debian/opt/cloud/bin/cs/CsAddress.py ../debian/opt/cloud/bin/cs/CsMonitor.py ../debian/opt/cloud/bin/cs/CsLoadBalancer.py ../debian/opt/cloud/bin/cs/__init__.py ../debian/opt/cloud/bin/cs/CsNetfilter.py ../debian/opt/cloud/bin/cs/CsGuestNetwork.py ../debian/opt/cloud/bin/cs/CsConfig.py ../debian/opt/cloud/bin/cs/CsRule.py ../debian/opt/cloud/bin/cs/CsRedundant.py ../debian/opt/cloud/bin/cs/CsApp.py ../debian/opt/cloud/bin/cs/CsHelper.py ../debian/opt/cloud/bin/line_edit.py ../debian/opt/cloud/bin/cs_cmdline.py ../debian/opt/cloud/bin/cs_firewallrules.py ../debian/opt/cloud/bin/cs_network_acl.py ../debian/root/monitorServices.py + '[' 0 -gt 0 ']' + echo 'Running pylint to check systemvm/python code for errors' Running pylint to check systemvm/python code for errors + pylint --disable=R,C,W TestCsAddress.py TestCsApp.py TestCsCmdLine.py TestCsConfig.py TestCsDatabag.py TestCsDhcp.py TestCsFile.py TestCsGuestNetwork.py TestCsHelper.py TestCsInterface.py TestCsNetfilter.py TestCsProcess.py TestCsRedundant.py TestCsRoute.py TestCsRule.py No config file found, using default configuration -------------------------------------------------------------------- Your code has been rated at 10.00/10 (previous run: 10.00/10, +0.00) ++ find ../debian -name '*.py' + pylint --disable=R,C,W ../debian/opt/cloud/bin/cs_loadbalancer.py ../debian/opt/cloud/bin/configure.py ../debian/opt/cloud/bin/master.py ../debian/opt/cloud/bin/cs_ip.py ../debian/opt/cloud/bin/update_config.py ../debian/opt/cloud/bin/cs_guestnetwork.py ../debian/opt/cloud/bin/passwd_server_ip.py ../debian/opt/cloud/bin/cs_staticroutes.py ../debian/opt/cloud/bin/cs_dhcp.py ../debian/opt/cloud/bin/cs_vpnusers.py ../debian/opt/cloud/bin/set_redundant.py ../debian/opt/cloud/bin/cs_remoteaccessvpn.py ../debian/opt/cloud/bin/baremetal-vr.py ../debian/opt/cloud/bin/cs_monitorservice.py ../debian/opt/cloud/bin/cs_site2sitevpn.py ../debian/opt/cloud/bin/merge.py ../debian/opt/cloud/bin/cs_vmp.py ../debian/opt/cloud/bin/cs_forwardingrules.py ../debian/opt/cloud/bin/cs_vmdata.py ../debian/opt/cloud/bin/vmdata.py ../debian/opt/cloud/bin/cs/CsStaticRoutes.py ../debian/opt/cloud/bin/cs/CsFile.py ../debian/opt/cloud/bin/cs/CsDhcp.py ../debian/opt/cloud/bin/cs/CsDatabag.py ../debian/opt/cloud/bin/cs/CsProcess.py ../debian/opt/cloud/bin/cs/CsRoute.py ../debian/opt/cloud/bin/cs/CsAddress.py ../debian/opt/cloud/bin/cs/CsMonitor.py ../debian/opt/cloud/bin/cs/CsLoadBalancer.py ../debian/opt/cloud/bin/cs/__init__.py ../debian/opt/cloud/bin/cs/CsNetfilter.py ../debian/opt/cloud/bin/cs/CsGuestNetwork.py ../debian/opt/cloud/bin/cs/CsConfig.py ../debian/opt/cloud/bin/cs/CsRule.py ../debian/opt/cloud/bin/cs/CsRedundant.py ../debian/opt/cloud/bin/cs/CsApp.py ../debian/opt/cloud/bin/cs/CsHelper.py ../debian/opt/cloud/bin/line_edit.py ../debian/opt/cloud/bin/cs_cmdline.py ../debian/opt/cloud/bin/cs_firewallrules.py ../debian/opt/cloud/bin/cs_network_acl.py ../debian/root/monitorServices.py No config file found, using default configuration -------------------------------------------------------------------- Your code has been rated at 10.00/10 (previous run: 10.00/10, +0.00) + '[' 0 -gt 0 ']' + echo 'Running systemvm/python unit tests' Running systemvm/python unit tests + nosetests . ....Device "eth0" does not exist. ..................... ---------------------------------------------------------------------- Ran 25 tests in 0.057s OK + exit 0 ``` On latest master: ```` > bash -x runtests.sh + export PYTHONPATH=../debian/opt/cloud/bin/ + PYTHONPATH=../debian/opt/cloud/bin/ + export PYTHONDONTWRITEBYTECODE=False + PYTHONDONTWRITEBYTECODE=False + echo 'Running pep8 to check systemvm/python code for errors' Running pep8 to check systemvm/python code for errors + pep8 --max-line-length=179 TestCsAddress.py TestCsApp.py TestCsCmdLine.py TestCsConfig.py TestCsDatabag.py TestCsDhcp.py TestCsFile.py TestCsGuestNetwork.py TestCsHelper.py TestCsInterface.py TestCsNetfilter.py TestCsProcess.py TestCsRedundant.py TestCsRoute.py TestCsRule.py ++ find ../debian -name '*.py' + pep8 --max-line-length=179 --exclude=monitorServices.py,baremetal-vr.py,passwd_server_ip.py ../debian/opt/cloud/bin/cs_loadbalancer.py ../debian/opt/cloud/bin/configure.py ../debian/opt/cloud/bin/master.py ../debian/opt/cloud/bin/cs_ip.py ../debian/opt/cloud/bin/update_config.py ../debian/opt/cloud/bin/cs_guestnetwork.py ../debian/opt/cloud/bin/passwd_server_ip.py ../debian/opt/cloud/bin/cs_staticroutes.py ../debian/opt/cloud/bin/cs_dhcp.py ../debian/opt/cloud/bin/cs_vpnusers.py ../debian/opt/cloud/bin/set_redundant.py ../debian/opt/cloud/bin/cs_remoteaccessvpn.py ../debian/opt/cloud/bin/baremetal-vr.py ../debian/opt/cloud/bin/cs_monitorservice.py ../debian/opt/cloud/bin/cs_site2sitevpn.py ../debian/opt/cloud/bin/merge.py ../debian/opt/cloud/bin/cs_vmp.py ../debian/opt/cloud/bin/cs_forwardingrules.py ../debian/opt/cloud/bin/cs_vmdata.py ../debian/opt/cloud/bin/vmdata.py ../debian/opt/cloud/bin/cs/CsStaticRoutes.py ../debian/opt/cloud/bin/cs/CsFile.py ../debian/opt/cloud/bin/cs/CsDhcp.py ../debian/opt/cloud/bin/cs/CsDatabag.py ../debian/opt/cloud/bin/cs/CsProcess.py ../debian/opt/cloud/bin/cs/CsRoute.py ../debian/opt/cloud/bin/cs/CsAddress.py ../debian/opt/cloud/bin/cs/CsMonitor.py ../debian/opt/cloud/bin/cs/CsLoadBalancer.py ../debian/opt/cloud/bin/cs/__init__.py ../debian/opt/cloud/bin/cs/CsNetfilter.py ../debian/opt/cloud/bin/cs/CsGuestNetwork.py ../debian/opt/cloud/bin/cs/CsConfig.py ../debian/opt/cloud/bin/cs/CsRule.py ../debian/opt/cloud/bin/cs/CsRedundant.py ../debian/opt/cloud/bin/cs/CsApp.py ../debian/opt/cloud/bin/cs/CsHelper.py ../debian/opt/cloud/bin/line_edit.py ../debian/opt/cloud/bin/cs_cmdline.py ../debian/opt/cloud/bin/cs_firewallrules.py ../debian/opt/cloud/bin/cs_network_acl.py ../debian/root/monitorServices.py + '[' 0 -gt 0 ']' + echo 'Running pylint to check systemvm/python code for errors' Running pylint to check systemvm/python code for errors + pylint --disable=R,C,W TestCsAddress.py TestCsApp.py TestCsCmdLine.py TestCsConfig.py TestCsDatabag.py TestCsDhcp.py TestCsFile.py TestCsGuestNetwork.py TestCsHelper.py TestCsInterface.py TestCsNetfilter.py TestCsProcess.py TestCsRedundant.py TestCsRoute.py TestCsRule.py No config file found, using default configuration -------------------------------------------------------------------- Your code has been rated at 10.00/10 (previous run: 10.00/10, +0.00) ++ find ../debian -name '*.py' + pylint --disable=R,C,W ../debian/opt/cloud/bin/cs_loadbalancer.py ../debian/opt/cloud/bin/configure.py ../debian/opt/cloud/bin/master.py ../debian/opt/cloud/bin/cs_ip.py ../debian/opt/cloud/bin/update_config.py ../debian/opt/cloud/bin/cs_guestnetwork.py ../debian/opt/cloud/bin/passwd_server_ip.py ../debian/opt/cloud/bin/cs_staticroutes.py ../debian/opt/cloud/bin/cs_dhcp.py ../debian/opt/cloud/bin/cs_vpnusers.py ../debian/opt/cloud/bin/set_redundant.py ../debian/opt/cloud/bin/cs_remoteaccessvpn.py ../debian/opt/cloud/bin/baremetal-vr.py ../debian/opt/cloud/bin/cs_monitorservice.py ../debian/opt/cloud/bin/cs_site2sitevpn.py ../debian/opt/cloud/bin/merge.py ../debian/opt/cloud/bin/cs_vmp.py ../debian/opt/cloud/bin/cs_forwardingrules.py ../debian/opt/cloud/bin/cs_vmdata.py ../debian/opt/cloud/bin/vmdata.py ../debian/opt/cloud/bin/cs/CsStaticRoutes.py ../debian/opt/cloud/bin/cs/CsFile.py ../debian/opt/cloud/bin/cs/CsDhcp.py ../debian/opt/cloud/bin/cs/CsDatabag.py ../debian/opt/cloud/bin/cs/CsProcess.py ../debian/opt/cloud/bin/cs/CsRoute.py ../debian/opt/cloud/bin/cs/CsAddress.py ../debian/opt/cloud/bin/cs/CsMonitor.py ../debian/opt/cloud/bin/cs/CsLoadBalancer.py ../debian/opt/cloud/bin/cs/__init__.py ../debian/opt/cloud/bin/cs/CsNetfilter.py ../debian/opt/cloud/bin/cs/CsGuestNetwork.py ../debian/opt/cloud/bin/cs/CsConfig.py ../debian/opt/cloud/bin/cs/CsRule.py ../debian/opt/cloud/bin/cs/CsRedundant.py ../debian/opt/cloud/bin/cs/CsApp.py ../debian/opt/cloud/bin/cs/CsHelper.py ../debian/opt/cloud/bin/line_edit.py ../debian/opt/cloud/bin/cs_cmdline.py ../debian/opt/cloud/bin/cs_firewallrules.py ../debian/opt/cloud/bin/cs_network_acl.py ../debian/root/monitorServices.py No config file found, using default configuration -------------------------------------------------------------------- Your code has been rated at 10.00/10 (previous run: 10.00/10, +0.00) + '[' 0 -gt 0 ']' + echo 'Running systemvm/python unit tests' Running systemvm/python unit tests + nosetests . ....Device "eth0" does not exist. ..................... ---------------------------------------------------------------------- Ran 25 tests in 0.052s OK + exit 0 ````
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
