khos2ow commented on issue #2584: Enhance and cleanup DatabaseUpgradeChecker URL: https://github.com/apache/cloudstack/pull/2584#issuecomment-382853689 I don't have the PR per se, I just have another branch on my fork to open a PR if need be :) These changes will be required for the use case you mentioned: - this snippet needs to be added in `4.9` branch (as previous): ``` _upgradeMap.put(CloudStackVersion.parse("4.9.3.0"), new DbUpgrade[] {new Upgrade4930to4940()}); ``` `new Upgrade4930to4940()` must be added to **all** other versions in `_updateMap` as well. - this snippet needs to be added in `4.10` branch (as previous): ``` _upgradeMap.put(CloudStackVersion.parse("4.9.3.0"), new DbUpgrade[] {new Upgrade4930to4940(), new Upgrade4940to41000()}); _upgradeMap.put(CloudStackVersion.parse("4.9.4.0"), new DbUpgrade[] {new Upgrade4940to41000()}); ``` `new Upgrade4930to4940()` must be added to **all** other versions in `_updateMap` as well. **Whereas** in `4.11` and `master` will be as follow: - snippet on for new approach: ``` DatabaseVersionHierarchy.builder() .next("4.0.0" , new Upgrade40to41()) ... .next("4.9.3.0" , new Upgrade4930to4940()) <-- modified to include 4.9.4.0 (original value: Upgrade4930to41000) .next("4.9.4.0" , new Upgrade4940to41000()) <-- added to go include 4.9.4.0 .next("4.10.0.0", new Upgrade41000to41100()) .next("4.11.0.0", new Upgrade41100to41110()) .build(); ```
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
