rhtyd commented on issue #2579: router: fix routing table for marked packets URL: https://github.com/apache/cloudstack/pull/2579#issuecomment-383048236 @DaanHoogland I checked `test_04_restart_network_wo_cleanup` and others test failures are not related to this PR, I'm seeing them on 4.11 - https://github.com/apache/cloudstack/pull/2376. The router related failures on xenserver are not seen but not caused by this PR. I'll go ahead and merge this based on your reviews from Daan, Wei and Rafael and try to address test failures in a separate PR. In future, reviewers are requested to use Github's review feature that makes it easy to count/reference in a long pr.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
