DaanHoogland commented on a change in pull request #2584: Enhance and cleanup DatabaseUpgradeChecker URL: https://github.com/apache/cloudstack/pull/2584#discussion_r183435064
########## File path: engine/schema/src/com/cloud/upgrade/DatabaseUpgradeChecker.java ########## @@ -51,11 +51,11 @@ import com.cloud.upgrade.dao.Upgrade440to441; import com.cloud.upgrade.dao.Upgrade441to442; import com.cloud.upgrade.dao.Upgrade442to450; -import com.cloud.upgrade.dao.Upgrade443to450; +import com.cloud.upgrade.dao.Upgrade443to444; Review comment: @khos2ow this changing import implies an altered upgrade path and makes me be warry about this going into 4.11 just before we start a 4.11.1 release process. Can you justify this change and the 452to460 path below and did you perform those upgrades during testing? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
