rafaelweingartner commented on a change in pull request #2598:
CLOUDSTACK-10360: Change the method name.
URL: https://github.com/apache/cloudstack/pull/2598#discussion_r183675863
##########
File path:
framework/config/src/main/java/org/apache/cloudstack/framework/config/impl/ConfigDepotImpl.java
##########
@@ -166,7 +166,7 @@ public ConfigurationDao global() {
return _configDao;
}
- public ScopedConfigStorage scoped(ConfigKey<?> config) {
+ public ScopedConfigStorage findStorage(ConfigKey<?> config) {
Review comment:
I would use something like `findScopedConfigStorage`. This `findStorage` can
be confused with find storage pool.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
