DaanHoogland commented on a change in pull request #2503: Support multiple 
volume access groups per compute cluster
URL: https://github.com/apache/cloudstack/pull/2503#discussion_r184846888
 
 

 ##########
 File path: 
plugins/hypervisors/vmware/src/main/java/com/cloud/storage/resource/VmwareStorageProcessor.java
 ##########
 @@ -2956,6 +3033,61 @@ public void handleTargets(boolean add, 
ModifyTargetsCommand.TargetTypeToRemove t
         }
     }
 
+    private String waitForDatastoreName(HostDatastoreSystemMO 
hostDatastoreSystemMO, String iqn) throws Exception {
+        long secondsToWait = 120;
 
 Review comment:
   just to butt in here; it is used at line 2661 as well. Is there any reason 
those two variables with the same name would have different values? I suspect 
not and if I'm right I'd like to see a constant.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to