rafaelweingartner commented on a change in pull request #2399: CLOUDSTACK-10223
delete snapshots when deleting domain
URL: https://github.com/apache/cloudstack/pull/2399#discussion_r184850779
##########
File path:
server/src/main/java/com/cloud/storage/snapshot/SnapshotManagerImpl.java
##########
@@ -715,7 +715,7 @@ public String getSecondaryStorageURL(SnapshotVO snapshot) {
@Override
public boolean deleteSnapshotDirsForAccount(long accountId) {
- List<VolumeVO> volumes = _volsDao.findByAccount(accountId);
+ List<VolumeVO> volumes =
_volsDao.findIncludingRemovedByAccount(accountId);
Review comment:
I just checked, and indeed snapshots have an entry in the `volumes` table.
On the other hand, I could not find entries for volumes, but this does not
affect the PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
