nitin-maharana commented on a change in pull request #2612: [migrateVolume API 
method] Filter disk offerings based on target storage pool selected
URL: https://github.com/apache/cloudstack/pull/2612#discussion_r184956662
 
 

 ##########
 File path: ui/scripts/sharedFunctions.js
 ##########
 @@ -2851,3 +2851,34 @@ cloudStack.createArrayOfParametersForCreatePodCommand = 
function (zoneId, data){
     cloudStack.addParameterToCommandUrlParameterArrayIfValueIsNotEmpty(array, 
"endIp", data.podEndIp);
     return array;
 }
+
+cloudStack.listDiskOfferings = function(options){
 
 Review comment:
   Hi @rafaelweingartner, This is a great improvement. I came across several 
places where the same AJAX call(Code) is repeated multiple places. We should 
put more of this to reduce redundancy. Thanks.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to