rafaelweingartner commented on a change in pull request #2616: 4.11.1.0:
Stabilization and blocker/issues fixes
URL: https://github.com/apache/cloudstack/pull/2616#discussion_r185504916
##########
File path: systemvm/debian/opt/cloud/bin/setup/patchsystemvm.sh
##########
@@ -37,6 +37,8 @@ patch_systemvm() {
echo "Restored keystore file and certs using backup" >> $logfile
fi
rm -fr $backupfolder
+ # Import global cacerts into 'cloud' service's keystore
+ keytool -importkeystore -srckeystore /etc/ssl/certs/java/cacerts
-destkeystore /usr/local/cloud/systemvm/certs/realhostip.keystore -srcstorepass
changeit -deststorepass vmops.com -noprompt || true
Review comment:
Why importing the Java default cacerts? I mean, why not using it directly?
I see that you are already modifying it to add the Let's encrypt public key.
Also, why do you need the `|| true` at the end?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
