khos2ow commented on a change in pull request #2616: 4.11.1.0: Stabilization 
and blocker/issues fixes
URL: https://github.com/apache/cloudstack/pull/2616#discussion_r185517562
 
 

 ##########
 File path: systemvm/debian/opt/cloud/bin/setup/cloud-early-config
 ##########
 @@ -71,16 +71,16 @@ config_guest() {
 
 get_boot_params() {
   case $HYPERVISOR in
-     xen-pv)
+     xen-pv|xen-domU)
 
 Review comment:
   in `hypervisor()` function above, line 44-52 should be moved to the very 
beginning of the function as the very first step to detect type of Xen, then 
let `virt-what` does its job. The reason is some HVM instances on Xen still 
being reported as `xen-domU` (which most probably they are pvhvm or something). 
But detecting if an instance is on PV or HVM through `dmesg` is accurate.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to