rhtyd commented on a change in pull request #2465: CLOUDSTACK-10232: SystemVMs
and VR to run as HVM on XenServer
URL: https://github.com/apache/cloudstack/pull/2465#discussion_r185723416
##########
File path: systemvm/debian/opt/cloud/bin/setup/cloud-early-config
##########
@@ -64,10 +71,17 @@ config_guest() {
get_boot_params() {
case $HYPERVISOR in
- xen-domU|xen-hvm)
+ xen-pv)
cat /proc/cmdline > $CMDLINE
sed -i "s/%/ /g" $CMDLINE
;;
+ xen-hvm)
+ if [ ! -f /usr/sbin/xenstore-read ]; then
+ log_it "ERROR: xentools not installed, cannot found xenstore-read"
&& exit 5
+ fi
+ /usr/sbin/xenstore-read vm-data/cloudstack/init >
/var/cache/cloud/cmdline
Review comment:
@khos2ow I think you're missing a big point and I'm wondering how you're
testing your changes. This script runs inside CloudStack's systemvmtemplate
that is based on Debian 9 for 4.11+. For the change in 4.11 branch, the
test/changes must be performed on Debian9 based guest vm only. In our built
template, the path to `xenstore-read` is at `/usr/bin`. Regarding the
`virt-what` comment, again the version of virt-what is specific to the Debian 9
based systemvmtemplate that would return xen-hvm in my tests across XenServer
6.5-7.x versions. I'll therefore keep my changes that are tested against 4.11
systemvmtemplate. Temporarily hosted here are latest 4.11 templates if you want
to try them: https://lab.yadav.cloud/systemvmtemplates/4.11/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
