rhtyd commented on a change in pull request #2616: 4.11.1.0: Stabilization and
blocker/issues fixes
URL: https://github.com/apache/cloudstack/pull/2616#discussion_r185724447
##########
File path: systemvm/debian/opt/cloud/bin/setup/cloud-early-config
##########
@@ -71,16 +71,16 @@ config_guest() {
get_boot_params() {
case $HYPERVISOR in
- xen-pv)
+ xen-pv|xen-domU)
Review comment:
@khos2ow I've replied here, for reference -
https://github.com/apache/cloudstack/pull/2465#discussion_r185519409
The `virt-what` output and changes in cloud-early-config should be tested
against 4.11+ systemvm template. The changes are specifically for
systemvmtemplate that is Debian9 based whose /boot is ext2 so as to allow for
PyGrub to work both by 6.x and 7.x XS versions, therefore even if we get into
`xen-domU` case, the pv cmdline args will be still available and patched to
boot `vmlinuz` with those args, irrespective to whether the systemvm boots as
pv or hvm they will all get the cmdline option via /proc/cmdline. My change
assumes that virt-what will return the correct output (also tested on 6.x, 7.x
versions), and therefore for pv and domU cases the patching approach should
read from /proc/cmdline.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
