GabrielBrascher commented on a change in pull request #2508: CLOUDSTACK-9114:
Reduce VR downtime during network restart
URL: https://github.com/apache/cloudstack/pull/2508#discussion_r185835963
##########
File path:
engine/orchestration/src/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java
##########
@@ -1216,6 +1180,32 @@ public void implementNetworkElementsAndResources(final
DeployDestination dest, f
}
}
+ protected void implementNetworkElements(final DeployDestination dest,
final ReservationContext context, final Network network, final NetworkOffering
offering, final List<Provider> providersToImplement)
Review comment:
Is there a reason for this method to be protected? What do you think about
making it private?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
