khos2ow commented on a change in pull request #2465: CLOUDSTACK-10232:
SystemVMs and VR to run as HVM on XenServer
URL: https://github.com/apache/cloudstack/pull/2465#discussion_r186106111
##########
File path: systemvm/debian/opt/cloud/bin/setup/cloud-early-config
##########
@@ -64,10 +71,17 @@ config_guest() {
get_boot_params() {
case $HYPERVISOR in
- xen-domU|xen-hvm)
+ xen-pv)
cat /proc/cmdline > $CMDLINE
sed -i "s/%/ /g" $CMDLINE
;;
+ xen-hvm)
+ if [ ! -f /usr/sbin/xenstore-read ]; then
+ log_it "ERROR: xentools not installed, cannot found xenstore-read"
&& exit 5
+ fi
+ /usr/sbin/xenstore-read vm-data/cloudstack/init >
/var/cache/cloud/cmdline
Review comment:
Thanks @rhtyd for the update, that's exactly how I have been testing, I'm
gonna double check on my side once again, but if you've done the testing and
validated the changes are good that's really good news.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
