nitin-maharana commented on a change in pull request #2629: Fix primary storage
count when deleting volumes
URL: https://github.com/apache/cloudstack/pull/2629#discussion_r186616221
##########
File path:
engine/storage/volume/src/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java
##########
@@ -1237,17 +1201,15 @@ private HostVO getHost(Long zoneId, HypervisorType
hypervisorType, boolean compu
return future;
}
- @Override
@DB
- public boolean destroyVolume(long volumeId) throws
ConcurrentOperationException {
+ @Override
+ public void destroyVolume(long volumeId) {
// mark volume entry in volumes table as destroy state
VolumeInfo vol = volFactory.getVolume(volumeId);
vol.stateTransit(Volume.Event.DestroyRequested);
snapshotMgr.deletePoliciesForVolume(volumeId);
vol.stateTransit(Volume.Event.OperationSucceeded);
-
- return true;
Review comment:
@rafaelweingartner, I figured out lately, I guess the change of return type
because it always returns true??
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
