rafaelweingartner commented on a change in pull request #2653: Generate MAC 
address if the MAC in command addNicToVirtualMachine is invalid
URL: https://github.com/apache/cloudstack/pull/2653#discussion_r189050380
 
 

 ##########
 File path: server/src/com/cloud/vm/UserVmManagerImpl.java
 ##########
 @@ -1228,12 +1230,22 @@ public UserVm addNicToVirtualMachine(AddNicToVMCmd 
cmd) throws InvalidParameterV
         return _vmDao.findById(vmInstance.getId());
     }
 
+    /**
+     * It checks if the given mac is null, in case of a null mac it calls 
method  {@link com.cloud.network.NetworkModel 
#getNextAvailableMacAddressInNetwork(long)} and returns the generated mac 
address 
 
 Review comment:
   "MAC" is an acronym. Therefore, would you mind capitalizing it in the Java 
documentation? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to