Jazz9 commented on issue #2650: Ceph RBD Feature flag update
URL: https://github.com/apache/cloudstack/issues/2650#issuecomment-390063811
 
 
   Additionally,
   
   Per per dev mailing list discussion with Wido. This following code controls 
the feature set.
   
   
https://github.com/apache/cloudstack/blob/master/plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java#L957
   
   private int rbdFeatures = (1 << 0); /* Feature 1<<0 means layering in RBD 
format 2 */
   > 
   rbd.clone(template.getName(), rbdTemplateSnapName, io, disk.getName(), 
   rbdFeatures, rbdOrder);
   
   
   I would suggest that we create a global setting that controls the feature 
flags.
   
   1. Default -1 to not specify any flags to rbd.clone. This should choose the 
defaults for the current version of Ceph.
   2. Specify a number the enable that feature code. ( 
https://ceph.com/geen-categorie/ceph-enable-the-object-map-feature/ )
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to