GabrielBrascher commented on a change in pull request #2653: Generate MAC
address if the MAC in command addNicToVirtualMachine is invalid
URL: https://github.com/apache/cloudstack/pull/2653#discussion_r189441308
##########
File path: server/src/com/cloud/vm/UserVmManagerImpl.java
##########
@@ -1228,12 +1230,22 @@ public UserVm addNicToVirtualMachine(AddNicToVMCmd
cmd) throws InvalidParameterV
return _vmDao.findById(vmInstance.getId());
}
+ /**
+ * If the given MAC address is invalid it returns the next available MAC
address
+ */
+ protected String
lookForNextAvailableMacAddressInNetworkIfMacIsInvalid(String macAddress, long
networkId) {
Review comment:
Good idea, I will update it. Thanks, @DaanHoogland!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
