GabrielBrascher commented on a change in pull request #2655: Handle Ceph.
URL: https://github.com/apache/cloudstack/pull/2655#discussion_r189447104
##########
File path:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtMigrateCommandWrapper.java
##########
@@ -415,6 +415,20 @@ private String getSourceFileDevText(Node diskNode) {
if (diskNodeAttribute != null) {
return diskNodeAttribute.getTextContent();
}
+
+ diskNodeAttribute =
diskNodeAttributes.getNamedItem("protocol");
+
+ if (diskNodeAttribute != null) {
Review comment:
@mike-tutkowski can `diskNodeAttribute` be blank or empty? If yes a
`StringUtils.isBlank(diskNodeAttribute)` would fit in this conditional.
Additionally, Do you think that we could benefit from an elaborated check
here? For instance, verify if it is a valid protocol.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
