mike-tutkowski commented on a change in pull request #2655: Handle Ceph.
URL: https://github.com/apache/cloudstack/pull/2655#discussion_r189497275
##########
File path:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtMigrateCommandWrapper.java
##########
@@ -415,6 +415,20 @@ private String getSourceFileDevText(Node diskNode) {
if (diskNodeAttribute != null) {
return diskNodeAttribute.getTextContent();
}
+
+ diskNodeAttribute =
diskNodeAttributes.getNamedItem("protocol");
+
+ if (diskNodeAttribute != null) {
Review comment:
I'm not sure I follow: diskNodeAttribute is of type Node (not String).
Once we query for the "protocol" attribute, if any, we then check if its
content equals "rbd" (which is the only protocol we care about here).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
