DaanHoogland commented on a change in pull request #2683: Add default L2
network offerings
URL: https://github.com/apache/cloudstack/pull/2683#discussion_r192725716
##########
File path:
engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java
##########
@@ -561,6 +561,35 @@ public void doInTransactionWithoutResult(final
TransactionStatus status) {
offering.setDedicatedLB(false);
_networkOfferingDao.update(offering.getId(), offering);
}
+
+ if
(_networkOfferingDao.findByUniqueName(NetworkOffering.DefaultL2NetworkOfferingNoVlan)
== null) {
Review comment:
can you create a method for addDefaultL2Offerings() ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
