DaanHoogland commented on a change in pull request #2683: Add default L2 
network offerings
URL: https://github.com/apache/cloudstack/pull/2683#discussion_r192725932
 
 

 ##########
 File path: server/src/main/java/com/cloud/server/ConfigurationServerImpl.java
 ##########
 @@ -1175,6 +1175,31 @@ public void 
doInTransactionWithoutResult(TransactionStatus status) {
                     _ntwkOfferingServiceMapDao.persist(offService);
                     s_logger.trace("Added service for the network offering: " 
+ offService);
                 }
+
+                NetworkOfferingVO l2NoVlan = new 
NetworkOfferingVO(NetworkOffering.DefaultL2NetworkOfferingNoVlan,
 
 Review comment:
   can you create a addDefaultL2Offerings(), please?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to